Skip to content

Make sketches_factor actually do something and fix exception race-case#145

Merged
etwest merged 8 commits intomainfrom
control_sketches
Feb 27, 2024
Merged

Make sketches_factor actually do something and fix exception race-case#145
etwest merged 8 commits intomainfrom
control_sketches

Conversation

@etwest
Copy link
Collaborator

@etwest etwest commented Feb 21, 2024

Main branch has problems:

  • Currently we have the sketches factor option in the configuration but it doesn't affect anything... oops.
  • When our threads throw an exception this can cause a race case resulting in memory errors instead of exiting gracefully.
  • log2(const expr) is not always a const expr with all compilers.
  • The pre_insert function builds a representation of the entire graph on an insert only stream. yikes. Instead we want to just maintain the spanning forest edges.

This pull request fixes all of those problems.

@etwest etwest requested a review from DanielDeLayo February 21, 2024 01:26
@etwest etwest requested a review from DanielDeLayo February 24, 2024 23:50
@etwest etwest merged commit db06e66 into main Feb 27, 2024
@etwest etwest deleted the control_sketches branch February 27, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants